Replace duplicated gpu_definition.tf by shared internal module#3448
Merged
Conversation
NOTE: keep ones in `schedmd-slurm-gcp-v5*` due to soon removal.
tpdownes
approved these changes
Dec 30, 2024
tpdownes
left a comment
Contributor
There was a problem hiding this comment.
I would like to review whether use of null (vs empty list) would help us avoid the need for this file, but I agree that a simple internal module is a better approach than code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add module
modules/internal/gpu-definitionto handle default values for GPUs list.NOTE: keep ones in
schedmd-slurm-gcp-v5*due to soon removal.