Add compact placement validations#3439
Merged
Merged
Conversation
ighosh98
reviewed
Dec 19, 2024
ighosh98
left a comment
Contributor
There was a problem hiding this comment.
Add a description to provide proper context on the fix. Please link the relevant documentation that covers the rules
Contributor
Author
|
ighosh98
reviewed
Dec 20, 2024
ighosh98
approved these changes
Dec 20, 2024
ankitkinra
approved these changes
Dec 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compact placement in GKE Standard node pools has certain limitations.
Added validations for 2nd and 5th limitation mentioned here: https://cloud.google.com/kubernetes-engine/docs/how-to/compact-placement#limitations-standard
3rd and 4th limitation can be changed over time, so not adding any validations for them.