Skip to content

Add max_distance variable#3413

Merged
alyssa-sm merged 1 commit into
GoogleCloudPlatform:developfrom
alyssa-sm:implemenet-max-distance
Jan 7, 2025
Merged

Add max_distance variable#3413
alyssa-sm merged 1 commit into
GoogleCloudPlatform:developfrom
alyssa-sm:implemenet-max-distance

Conversation

@alyssa-sm

@alyssa-sm alyssa-sm commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR:

  • Adds placement_max_distance variable to SlurmGCP v6 nodeset
  • Modifies resume.py to adjust chunk size based on max distance if provided

@alyssa-sm alyssa-sm added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 16, 2024
@alyssa-sm alyssa-sm self-assigned this Dec 16, 2024
@alyssa-sm alyssa-sm force-pushed the implemenet-max-distance branch 2 times, most recently from 2260e0c to af7bcff Compare December 16, 2024 21:22
@alyssa-sm alyssa-sm marked this pull request as ready for review December 16, 2024 21:23
@alyssa-sm alyssa-sm force-pushed the implemenet-max-distance branch 2 times, most recently from 5966e0d to 679f87a Compare December 16, 2024 21:54
@alyssa-sm alyssa-sm force-pushed the implemenet-max-distance branch 6 times, most recently from 6b47719 to 650f148 Compare December 17, 2024 04:30
@alyssa-sm alyssa-sm requested a review from mr0re1 December 17, 2024 04:34
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Dec 17, 2024
mr0re1
mr0re1 reviewed Dec 17, 2024
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/partition.tf Outdated
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Dec 17, 2024
@alyssa-sm alyssa-sm force-pushed the implemenet-max-distance branch 3 times, most recently from df42731 to e83d0bc Compare December 23, 2024 07:10
@alyssa-sm alyssa-sm requested a review from mr0re1 December 23, 2024 19:03
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Dec 23, 2024
@alyssa-sm alyssa-sm force-pushed the implemenet-max-distance branch from e83d0bc to c290e52 Compare January 7, 2025 05:24
@alyssa-sm alyssa-sm requested a review from mr0re1 January 7, 2025 05:24
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Jan 7, 2025
@alyssa-sm alyssa-sm merged commit 746b886 into GoogleCloudPlatform:develop Jan 7, 2025
@alyssa-sm alyssa-sm deleted the implemenet-max-distance branch January 7, 2025 21:04
@RachaelSTamakloe RachaelSTamakloe mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@alyssa-sm alyssa-sm

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alyssa-sm @mr0re1