Skip to content

Update README with GKE parallelstore related example blueprint details#3409

Merged
mohitchaurasia91 merged 5 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:fix-ps-blueprint
Dec 19, 2024
Merged

Update README with GKE parallelstore related example blueprint details#3409
mohitchaurasia91 merged 5 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:fix-ps-blueprint

Conversation

@mohitchaurasia91

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mohitchaurasia91 mohitchaurasia91 added the documentation Improvements or additions to documentation label Dec 16, 2024
@mohitchaurasia91 mohitchaurasia91 self-assigned this Dec 16, 2024
@mohitchaurasia91 mohitchaurasia91 added the release-improvements Added to release notes under the "Improvements" heading. label Dec 16, 2024

@ankitkinra ankitkinra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the name of this blueprint to be gke-storage-managed-parallelstore to reflect that we delete this parallelstore as well ? Although I don't know if managed still conveys the same meaning

@mohitchaurasia91

Copy link
Copy Markdown
Contributor Author

Can we update the name of this blueprint to be gke-storage-managed-parallelstore to reflect that we delete this parallelstore as well ? Although I don't know if managed still conveys the same meaning

Agree to that, it align well with terraform definition of managed resources, providing a clean separation between terraform (managed) resources and data resources.

Comment thread examples/README.md Outdated
@mohitchaurasia91 mohitchaurasia91 merged commit 6d4d8f7 into GoogleCloudPlatform:develop Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants