Skip to content

Expose cluster deletion protection#3392

Merged
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/add-cluster-deletion-protection
Dec 12, 2024
Merged

Expose cluster deletion protection#3392
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/add-cluster-deletion-protection

Conversation

@annuay-google

@annuay-google annuay-google commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Why are we making this change?

Some of our users prefer that their mission critical clusters be not deleted unintentionally. This change allows them to do that.

What

Expose deletion protection as a field. Input is piped directly to deletion_protection field in google_container_cluster

Testing

  • Created a cluster with deletion protection disabled, verified it could be torn down with gcluster destroy
  • Created a cluster with deletion protection enabled, verified gcluster destroy threw an error
  • Set deletion protection = false on above cluster, applied. Then ran gcluster destroy and verified cluster was torn down

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Dec 11, 2024
@annuay-google annuay-google changed the base branch from main to develop December 11, 2024 20:53
@tpdownes tpdownes assigned annuay-google and unassigned tpdownes Dec 12, 2024
@annuay-google annuay-google merged commit 77322a5 into GoogleCloudPlatform:develop Dec 12, 2024
@annuay-google annuay-google deleted the annuay/add-cluster-deletion-protection branch December 12, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants