Untangle exclusive and enable_placement, update examples.#3362
Merged
Conversation
exclusive and enable_placement, update examples.
Contributor
|
There is a error in |
alyssa-sm
approved these changes
Dec 10, 2024
ebde2b9 to
955dc44
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations:
Enable usage of placements with dense reservations.
Encourage usage of placements by making them to always work regardless of nodeset configuration.
Done:
Remove constraints:
"If a reservation is specified,
var.enable_placementmust befalse" - dense reservations support external placements, non-dense reservation will ignore Slurm-created placement."If any non-static nodesets has
enable_placement,var.exclusivemust be set true" - nodeset-wise (non-exclusive) placement can be used with dynamic nodes.Remove
enable_placement: falsefrom SlurmV6 examples.Reasons for users to set
enable_placement=false: