make upgrade settings configurable#3359
Merged
Merged
Conversation
efa88ab to
2d79cbe
Compare
2d79cbe to
2e21505
Compare
4dcfcbf to
9f27ac1
Compare
9f27ac1 to
f969c00
Compare
a63174d to
75a60c3
Compare
annuay-google
approved these changes
Dec 10, 2024
Contributor
Author
|
Closing #3343 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Resolves issue #3343
This PR adds limited support for surge strategy. We would re-evaluate if blue green support as specified by terraform is needed in a future PR
In case, customers enter invalid configurations, we would throw an error before cluster provisioning starts by leveraging the preconditions.
Why coalesce over try?
try does not treat undefined variables as an error state as it catches for errors in the evaluation process. Coalesce is a better fit for our use case
Testing Proof:
Successfully provisioned a cluster with default parameters.