Include MemSpecLimit when calculating defmem#3300
Merged
mr0re1 merged 1 commit intoJan 10, 2025
Merged
Conversation
7243a02 to
c030b28
Compare
mr0re1
reviewed
Dec 19, 2024
mr0re1
approved these changes
Dec 19, 2024
c030b28 to
84e3d38
Compare
84e3d38 to
a9f4617
Compare
Contributor
Author
|
ready to go |
Collaborator
|
/gcbrun |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent OOMKiller killing random processes on the node it is possible to define
MemSpecLimitwhich reserves some of the memory for the system and limit job memory below what is available on the node.This example reserves 1024MB of RAM for system on the node:
But with such definition, running job fails with:
Though running job with:
Succeeds, as it requests less memory.
This change subtracts reserved memory from total memory available on the instance before calculating
DefMemPerCPUwhich results in default memory claim within available memory.This is most visible on 1 CPU nodes, but with larger nodes, at least one CPU may not be available for scheduling due to this.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.