Skip to content

Add Cloud Logging to required APIs for Packer module#2031

Merged
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:packer_logging
Dec 8, 2023
Merged

Add Cloud Logging to required APIs for Packer module#2031
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:packer_logging

Conversation

@tpdownes

@tpdownes tpdownes commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Because our recommended use of the Packer module relies on startup-scripts, Cloud Logging is a critical API to be enabled for reviewing failures. A task has been created to examine the remaining modules for any locations where Cloud Logging might be valuable.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes requested a review from mr0re1 December 8, 2023 14:40
@tpdownes tpdownes added the release-chore To not include into release notes label Dec 8, 2023
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Dec 8, 2023
@tpdownes tpdownes enabled auto-merge December 8, 2023 16:06
@tpdownes tpdownes disabled auto-merge December 8, 2023 16:06
@tpdownes tpdownes enabled auto-merge December 8, 2023 16:09
@tpdownes tpdownes merged commit db9b4f4 into GoogleCloudPlatform:develop Dec 8, 2023
@tpdownes tpdownes deleted the packer_logging branch December 8, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants