Skip to content

Hotfix for vm-instance to allow image names to be used correctly#1930

Merged
cdunbar13 merged 3 commits into
GoogleCloudPlatform:release-candidatefrom
cdunbar13:vm-instance-trigger-fix2
Nov 3, 2023
Merged

Hotfix for vm-instance to allow image names to be used correctly#1930
cdunbar13 merged 3 commits into
GoogleCloudPlatform:release-candidatefrom
cdunbar13:vm-instance-trigger-fix2

Conversation

@cdunbar13

Copy link
Copy Markdown
Collaborator

Allows name or family to be used for the trigger, which was breaking the tests. Exclusivity of the term is validated in variables.tf.

@cdunbar13 cdunbar13 requested review from cboneti and mr0re1 November 3, 2023 18:20
@cdunbar13 cdunbar13 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Nov 3, 2023
Comment thread modules/compute/vm-instance/main.tf Outdated
@mr0re1 mr0re1 assigned cdunbar13 and unassigned mr0re1 Nov 3, 2023
@cdunbar13 cdunbar13 requested a review from mr0re1 November 3, 2023 18:35
@cdunbar13 cdunbar13 assigned mr0re1 and unassigned cdunbar13 Nov 3, 2023
@cdunbar13 cdunbar13 force-pushed the vm-instance-trigger-fix2 branch from 1efcd63 to bac75a2 Compare November 3, 2023 18:37
@mr0re1 mr0re1 assigned cdunbar13 and unassigned mr0re1 Nov 3, 2023
@cdunbar13 cdunbar13 removed the request for review from cboneti November 3, 2023 19:55
@cdunbar13 cdunbar13 merged commit 34d3b40 into GoogleCloudPlatform:release-candidate Nov 3, 2023
@cdunbar13 cdunbar13 deleted the vm-instance-trigger-fix2 branch November 3, 2023 19:57
@mr0re1 mr0re1 mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants