Skip to content

Re-raise error in rescue block of slurm integration test#1902

Merged
cdunbar13 merged 1 commit into
GoogleCloudPlatform:developfrom
cdunbar13:reraise-error-rescue-slurm-test
Oct 31, 2023
Merged

Re-raise error in rescue block of slurm integration test#1902
cdunbar13 merged 1 commit into
GoogleCloudPlatform:developfrom
cdunbar13:reraise-error-rescue-slurm-test

Conversation

@cdunbar13

Copy link
Copy Markdown
Collaborator

Noticed during today's daily tests that if an integration test fails (specifically things like test-mounts.yml), the rescue block of the slurm-integration-test.yml blocks the error from propagating to cloud build so we don't notice it.

This PR creates an error and propagates it upward similar to how it is done during the rescue block of the setup portion of the integration test.

@cdunbar13 cdunbar13 added the release-chore To not include into release notes label Oct 30, 2023
@cdunbar13 cdunbar13 requested a review from nick-stroud October 30, 2023 14:48
Comment thread tools/cloud-build/daily-tests/ansible_playbooks/slurm-integration-test.yml Outdated
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Oct 31, 2023
@cdunbar13 cdunbar13 force-pushed the reraise-error-rescue-slurm-test branch from 316bfa8 to 775c930 Compare October 31, 2023 12:34
@cdunbar13 cdunbar13 merged commit 125bfb6 into GoogleCloudPlatform:develop Oct 31, 2023
@cdunbar13 cdunbar13 deleted the reraise-error-rescue-slurm-test branch October 31, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants