Improve pre existing vpc failure mechanism#1897
Merged
alyssa-sm merged 1 commit intoNov 7, 2023
Merged
Conversation
nick-stroud
requested changes
Nov 1, 2023
c2081e2 to
79b6d25
Compare
nick-stroud
approved these changes
Nov 6, 2023
79b6d25 to
cc37e06
Compare
cc37e06 to
4e4c3a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes pre-existing-vpc to check whether a network can be found using post-conditions.
Prior to this PR, failure to find a valid network/subnetwork would present an error like this:
With the addition of the post-conditions, the error message looks like this when the network/subnetwork cannot be found.
TESTED:
The following cases were tested.
- Blueprints with valid networks and subnetworks
- Blueprints with valid a network and an invalid subnetwork
- Blueprints with an invalid network and invalid subnetwork