Skip to content

Update ansible's usage of virtualenv to venv#1877

Merged
cdunbar13 merged 1 commit into
GoogleCloudPlatform:developfrom
cdunbar13:venv-update
Oct 25, 2023
Merged

Update ansible's usage of virtualenv to venv#1877
cdunbar13 merged 1 commit into
GoogleCloudPlatform:developfrom
cdunbar13:venv-update

Conversation

@cdunbar13

Copy link
Copy Markdown
Collaborator

Because of a fix to install_ansible.sh, we need to switch to using venv in the ansible scripts (virtualenv is no longer installed in installed_ansible.sh).

@cdunbar13 cdunbar13 requested a review from tpdownes October 25, 2023 14:22
@cdunbar13 cdunbar13 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Oct 25, 2023

@tpdownes tpdownes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge once previous failing tests have passed.

@tpdownes tpdownes assigned cdunbar13 and unassigned tpdownes Oct 25, 2023
@cdunbar13 cdunbar13 merged commit 220eced into GoogleCloudPlatform:develop Oct 25, 2023
@cdunbar13 cdunbar13 deleted the venv-update branch October 25, 2023 15:38
@mr0re1 mr0re1 mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants