Validate runtime dependencies before doing deploy#1875
Merged
Conversation
deploydeploy
tpdownes
suggested changes
Oct 30, 2023
Contributor
There was a problem hiding this comment.
The technical implementation LGTM. I suggest we improve the error messages from
❯ ghpc deploy image-builder-001
Error: must have a copy of packer installed in PATH (detailed error below)
exec: "packer": executable file not found in $PATH
❯ ghpc deploy image-builder-001
Error: must have a copy of terraform installed in PATH (detailed error below)
exec: "terraform": executable file not found in $PATH
to
❯ ghpc deploy image-builder-001
Error: must have a copy of packer installed in PATH (obtain at https://packer.io)
exec: "packer": executable file not found in $PATH
❯ ghpc deploy image-builder-001
Error: must have a copy of terraform installed in PATH (obtain at https://terraform.io)
exec: "terraform": executable file not found in $PATH
6ba2dc4 to
e64130d
Compare
tpdownes
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.