Skip to content

Ignore exit code when collecting partition info in Slurm integration test#1839

Merged
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:fix_test
Oct 14, 2023
Merged

Ignore exit code when collecting partition info in Slurm integration test#1839
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
tpdownes:fix_test

Conversation

@tpdownes

Copy link
Copy Markdown
Contributor

Several recent integrations tests have failed to cleanup because this task attempts (and fails) to run sinfo on a cluster that did not successfully start. This will allow the always block to run to completion.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes assigned tpdownes and harshthakkar01 and unassigned tpdownes Oct 13, 2023
@tpdownes tpdownes added the release-chore To not include into release notes label Oct 13, 2023
@tpdownes tpdownes merged commit 634a9f7 into GoogleCloudPlatform:develop Oct 14, 2023
@tpdownes tpdownes deleted the fix_test branch October 14, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants