Update ramble modules to have data file management#1837
Merged
nick-stroud merged 5 commits intoOct 19, 2023
Conversation
This commit updates the ramble modules to have similar functionality to the spack modules, including data file creation / transfer.
Previously, the spack and ramble execute modules assumed a gcs bucket was passed in (to allow them to be chained together). This commit updates both modules to allow the execute and setup to be used independently.
nick-stroud
requested changes
Oct 16, 2023
49bfffb to
ca61557
Compare
nick-stroud
requested changes
Oct 17, 2023
fd6d951 to
5ad517d
Compare
nick-stroud
requested changes
Oct 18, 2023
Collaborator
|
My comments are under the assumption that the following usage is permitted: If we get a little down the road and we want to change these assumptions, and the expression of theses assumptions in the code, I think that is fine. But if the above are our expectations then the code should reflect that. |
nick-stroud
approved these changes
Oct 19, 2023
Collaborator
|
Running tests. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge updates the ramble modules to have similar functionality to the spack modules, including data file creation / transfer.
Submission Checklist
Please take the following actions before submitting this pull request.