[not for merge] Trying the Libraries BOM with the shared dependencies BOM content by suztomo · Pull Request #2162 · GoogleCloudPlatform/cloud-opensource-java

suztomo · 2021-07-30T16:36:01Z

This PR is not going to be merged.

Trying replacing the shared dependencies BOM content to see any failures.

suztomo · 2021-07-30T18:00:44Z

google-oauth-client-bom includes google-oauth-client-assembly, which depends on google-play-services:google-play-services. This artifact requires a special installation.

[INFO] Running com.google.cloud.MaximumLinkageErrorsTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Jul 30, 2021 4:41:35 PM com.google.cloud.tools.opensource.classpath.LinkageChecker create
SEVERE: com.google.android.google-play-services:google-play-services:jar:1 was not resolved. Dependency path: null > com.google.api-client:google-api-client-android:jar:1.32.1 (compile) > com.google.android.google-play-services:google-play-services:jar:1 (provided)
Jul 30, 2021 4:41:35 PM com.google.cloud.tools.opensource.classpath.LinkageChecker create
SEVERE: com.google.oauth-client:google-oauth-client-assembly:jar:1.31.5 was not resolved. Dependency path: null > com.google.oauth-client:google-oauth-client-assembly:jar:1.31.5 (compile)
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 96.174 s <<< FAILURE! - in com.google.cloud.MaximumLinkageErrorsTest
Error:  testForNewLinkageErrors(com.google.cloud.MaximumLinkageErrorsTest)  Time elapsed: 96.132 s  <<< ERROR!
java.io.IOException: Could not resolve 2 dependencies. See the message above for details.
	at com.google.cloud.MaximumLinkageErrorsTest.testForNewLinkageErrors(MaximumLinkageErrorsTest.java:52)

suztomo · 2021-07-30T18:18:25Z

Same error on google-api-client-android

SEVERE: com.google.android.google-play-services:google-play-services:jar:1 was not resolved. Dependency path: null > com.google.api-client:google-api-client-android:jar:1.32.1 (compile) > com.google.android.google-play-services:google-play-services:jar:1 (provided)
Jul 30, 2021 4:41:35 PM com.google.cloud.tools.opensource.classpath.LinkageChecker create
SEVERE: com.google.oauth-client:google-oauth-client-assembly:jar:1.31.5 was not resolved. Dependency path: null > com.google.oauth-client:google-oauth-client-assembly:jar:1.31.5 (compile)

suztomo · 2021-07-30T18:28:28Z

google-api-client-assembly

SEVERE: com.google.android.google-play-services:google-play-services:jar:1 was not resolved. Dependency path: null > com.google.api-client:google-api-client-assembly:pom:1.32.1 (compile) > com.google.api-client:google-api-client-android:jar:1.32.1 (compile) > com.google.android.google-play-services:google-play-services:jar:1 (provided)

elharo · 2021-07-30T18:36:50Z

I've hit that play services issue before, though not, so far as I recall, in oauth-client. It's worth trying to rip that out at the root. We really shouldn't need it. We also might not need assemblies any more.

suztomo · 2021-07-30T18:43:34Z

@elharo Thanks. I agree. I'll try to get rid of these artifacts from their BOMs after checking whether they are unused or not.

suztomo · 2021-07-30T18:44:27Z

boms/cloud-oss-bom/pom.xml

+        <artifactId>google-cloud-core</artifactId>
+        <version>${google.core.version}</version>
+        <type>test-jar</type>


Linkage Checker is not handling the google-cloud-core artifact that appears multiple times with different classifiers.

The error is shown as if google-cloud-core is missing.

Error: testForNewLinkageErrors(com.google.cloud.MaximumLinkageErrorsTest) Time elapsed: 161.994 s <<< FAILURE! java.lang.AssertionError: Baseline BOM: com.google.cloud:libraries-bom:20.9.0 Newly introduced problems: Class com.google.cloud.ServiceOptions is not found; referenced by 24 class files com.google.cloud.ServiceOptionsTest (com.google.cloud:google-cloud-core:1.95.4) com.google.cloud.BaseWriteChannelTest (com.google.cloud:google-cloud-core:1.95.4) com.google.cloud.SerializationTest (com.google.cloud:google-cloud-core:1.95.4) com.google.cloud.bigquery.BigQueryOptions (com.google.cloud:google-cloud-bigquery:1.137.1)

The dependency management includes type and classifier.

pom.xml:

<?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> <groupId>org.example</groupId> <artifactId>maven-dependency-management-classifier</artifactId> <version>1.0-SNAPSHOT</version> <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <maven.compiler.source>1.8</maven.compiler.source> <maven.compiler.target>1.8</maven.compiler.target> </properties> <dependencyManagement> <dependencies> <dependency> <groupId>com.google.cloud</groupId> <artifactId>google-cloud-core</artifactId> <version>1.96.0</version> </dependency> </dependencies> </dependencyManagement> <dependencies> <dependency> <groupId>com.google.cloud</groupId> <artifactId>google-cloud-core</artifactId> <type>test-jar</type> </dependency> <dependency> <groupId>com.google.cloud</groupId> <artifactId>google-cloud-core</artifactId> <classifier>tests</classifier> </dependency> </dependencies> </project>

The build fails:

suztomo@suztomo-macbookpro44 maven-dependency-management-classifier % mvn dependency:tree [INFO] Scanning for projects... [ERROR] [ERROR] Some problems were encountered while processing the POMs: [ERROR] 'dependencies.dependency.version' for com.google.cloud:google-cloud-core:test-jar is missing. @ line 28, column 17 [ERROR] 'dependencies.dependency.version' for com.google.cloud:google-cloud-core:jar:tests is missing. @ line 33, column 17 @ [ERROR] The build could not read 1 project -> [Help 1] [ERROR] [ERROR] The project org.example:maven-dependency-management-classifier:1.0-SNAPSHOT (/Users/suztomo/maven-dependency-management-classifier/pom.xml) has 2 errors [ERROR] 'dependencies.dependency.version' for com.google.cloud:google-cloud-core:test-jar is missing. @ line 28, column 17 [ERROR] 'dependencies.dependency.version' for com.google.cloud:google-cloud-core:jar:tests is missing. @ line 33, column 17 [ERROR]

Interestingly, the two Maven coordinates (com.google.cloud:google-cloud-core:tests and com.google.cloud:google-cloud-core:test-jar:tests) refer to the same JAR file.

The code change at the former: https://github.com/googleapis/java-shared-dependencies/pull/59/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R246

The code change at the latter: https://github.com/googleapis/java-shared-dependencies/pull/40/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R286

As per documentation (http://maven.apache.org/guides/mini/guide-attached-tests.html), test-jar type and the tests classifier should be specified.

…cies_bom

suztomo · 2021-08-12T15:31:08Z

The classifier fix remediated the problem around Class com.google.cloud.ServiceOptions is not found.

Still there are linkage errors on the test related dependencies, as expected.

Error:  testForNewLinkageErrors(com.google.cloud.MaximumLinkageErrorsTest)  Time elapsed: 208.565 s  <<< FAILURE!
java.lang.AssertionError: 
Baseline BOM: com.google.cloud:libraries-bom:20.9.0
Newly introduced problems:
Class org.easymock.EasyMock is not found;
  referenced by 3 class files
    com.google.cloud.BatchResultTest (com.google.cloud:google-cloud-core:jar:tests:1.95.4)
    com.google.cloud.testing.BaseEmulatorHelperTest (com.google.cloud:google-cloud-core:jar:tests:1.95.4)
    com.google.cloud.BaseServiceExceptionTest (com.google.cloud:google-cloud-core:jar:tests:1.95.4)
Class org.easymock.IExpectationSetters is not found;
  referenced by 2 class files
    com.google.cloud.testing.BaseEmulatorHelperTest (com.google.cloud:google-cloud-core:jar:tests:1.95.4)
    com.google.cloud.BaseServiceExceptionTest (com.google.cloud:google-cloud-core:jar:tests:1.95.4)
Class com.google.apphosting.base.protos.api.ApiBasePb$StringProto is not found;
  referenced by 1 class file
    com.google.appengine.api.datastore.AsyncDatastoreServiceImpl (com.google.appengine:appengine-api-1.0-sdk:1.9.87)
Class com.google.apphosting.base.protos.api.ApiBasePb$StringProto$Builder is not found;
  referenced by 1 class file
    com.google.appengine.api.datastore.AsyncDatastoreServiceImpl (com.google.appengine:appengine-api-1.0-sdk:1.9.87)
Class com.google.apphosting.base.protos.api.ApiBasePb is not found;
  referenced by 1 class file
...

Trying replacing the shared dependencies BOM content

189f01f

google-cla bot added the cla: yes label Jul 30, 2021

suztomo changed the title ~~Trying replacing the shared dependencies BOM content~~ Trying the Libraries BOM with the shared dependencies BOM content Jul 30, 2021

suztomo added 2 commits July 30, 2021 14:02

Removing google-oauth-client-assembly

c5f012c

Excluding google-api-client-android

3d9c402

Excluded google-api-client-assembly

81ec4f5

suztomo commented Jul 30, 2021

View reviewed changes

suztomo changed the title ~~Trying the Libraries BOM with the shared dependencies BOM content~~ [not for merge] Trying the Libraries BOM with the shared dependencies BOM content Jul 30, 2021

suztomo mentioned this pull request Aug 11, 2021

Linkage Checker to work with artifacts with classifiers #2173

Closed

Merge remote-tracking branch 'origin/master' into try_shared_dependen…

9ae2bed

…cies_bom

suztomo mentioned this pull request Sep 7, 2021

Libraries BOM: Updating Google Cloud BOM to 0.161.0 and associated dependencies #2211

Merged

suztomo added the kokoro:run force run kokoro label Sep 14, 2021

suztomo closed this Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[not for merge] Trying the Libraries BOM with the shared dependencies BOM content#2162

[not for merge] Trying the Libraries BOM with the shared dependencies BOM content#2162
suztomo wants to merge 5 commits intomasterfrom
try_shared_dependencies_bom

suztomo commented Jul 30, 2021 •

edited

Loading

Uh oh!

suztomo commented Jul 30, 2021 •

edited

Loading

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

elharo commented Jul 30, 2021

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

suztomo Jul 30, 2021

Uh oh!

suztomo Jul 30, 2021 •

edited

Loading

Uh oh!

suztomo Jul 30, 2021 •

edited

Loading

Uh oh!

suztomo commented Aug 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

suztomo commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

elharo commented Jul 30, 2021

Uh oh!

suztomo commented Jul 30, 2021

Uh oh!

suztomo Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

suztomo Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo commented Aug 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

suztomo commented Jul 30, 2021 •

edited

Loading

suztomo commented Jul 30, 2021 •

edited

Loading

suztomo Jul 30, 2021 •

edited

Loading

suztomo Jul 30, 2021 •

edited

Loading