Linkage monitor to read file to get list of artifacts for a repository (when necessary)#1961
Closed
suztomo wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Closed
Linkage monitor to read file to get list of artifacts for a repository (when necessary)#1961suztomo wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
suztomo wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
suztomo
commented
Feb 26, 2021
Comment on lines
+1
to
+3
| com.google.api:gax | ||
| com.google.api:gax-grpc | ||
| com.google.api:gax-httpjson No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This is the file in gax-java repository will look like.
Contributor
Author
|
Closing this in favor of #1962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@elharo As discussed, this replaces the last month's https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1920/files.
What is the file will look like?
gax-java repository to have linkage-monitor-artifacts.txt in the root directory.
CC: @chingor13 who owns gax-java
Why versionless coordinates?
One thing I didn't know during the discussion was that the versions of generated artifacts are not static. This PR uses
RepositoryUtility.findVersions()to find the latest version for the versionless coordinates listed inlinkage-monitor-artifacts.txt. (Alternatively we could modify gax-java's build.gradle to generate linkage-monitor-artifacts.txt with concrete coordinates. This seemed complex compared toRepositoryUtility.findVersions()).Fixes #1958