fix: allow group and other access to Unix socket #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
approved these changes
Sep 21, 2022
Contributor
hessjcg
left a comment
There was a problem hiding this comment.
Consider updating the printed error message when setting the file perms fails.
internal/proxy/proxy.go
Outdated
| // Best effort. If this call fails, group and other won't have write | ||
| // access. | ||
| err := os.Chmod(address, 0777) | ||
| fmt.Println(err) |
Contributor
There was a problem hiding this comment.
Maybe put a more descriptive warning message here so that the ops engineer has more context when this throws an error.
fmt.Printf("unable to set permissions on unix socket for %v: %v", address, err)
Member
Author
There was a problem hiding this comment.
We probably should add this error line back into the Cloud SQL Proxy too. I'll send that as a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1405.