Add BigTableIOLT#759
Conversation
There was a problem hiding this comment.
The cloud documentation suggests ..."Bigtable can scale to billions of rows and thousands of columns" so this diagonal structured key-value might not be the typical use case for Bigtable
We possibly need a numColumns in Configuration, default set to 1 and make the column key String.format("value%09d", index%numColumn)
There was a problem hiding this comment.
Not sure if this is the reason of apache/beam#27022. Also going to investigate it
There was a problem hiding this comment.
I tried to set multiple columns as you suggested, it didn't help with the issue.
There was a problem hiding this comment.
I find the cause is
- cell does not have set timestamp, so it default to epoch (1970-01-01)
- the createTable has a garbage collection policy of 1h, so large amount data written triggers GC and some records get deleted
We need to use .setTimestampMicros(java.time.Instant.now().toEpochMilli()*1000) for Mutation.SetCell
There was a problem hiding this comment.
createTable has a default maxAge of 1h. This causes cells without setting timestamp (default to epoch) gets garbage collected. I think it should be never by default. What do you think @pranavbhandari24
There was a problem hiding this comment.
I've updated the javadoc to make it clearer, please check
There was a problem hiding this comment.
That's interesting. Yeah, I'd agree that the data should never be garbage collected (if that is an option)
Will look into this.
eeb6bcd to
fbcbd4e
Compare
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
Abacn
left a comment
There was a problem hiding this comment.
Thanks, this looks pretty solid to me, just had a few minor comments.
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
a9eb628 to
751cf7f
Compare
Abacn
left a comment
There was a problem hiding this comment.
Thanks for the quick iteration. Last few comments.
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
...gle-cloud-platform/src/test/java/com/google/cloud/teleport/it/gcp/bigtable/BigTableIOLT.java
Outdated
Show resolved
Hide resolved
1a5c6d7 to
64b55d8
Compare
|
Thanks, no need to deal with "This branch is out-of-date with the base branch" in the GitHub side. This will be merged once internal test passes |
No description provided.