Skip to content

Add test coverage for non-ascii Template parameter#2192

Merged
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn:non-ascii-test
Feb 14, 2025
Merged

Add test coverage for non-ascii Template parameter#2192
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn:non-ascii-test

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Feb 13, 2025

No description provided.

@Abacn Abacn force-pushed the non-ascii-test branch 2 times, most recently from 85dc057 to 67685be Compare February 13, 2025 22:22
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (40e1a8b) to head (f77bdf6).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2192      +/-   ##
============================================
+ Coverage     46.97%   47.06%   +0.08%     
- Complexity     4047     4050       +3     
============================================
  Files           876      876              
  Lines         52203    52218      +15     
  Branches       5502     5505       +3     
============================================
+ Hits          24524    24577      +53     
+ Misses        25922    25881      -41     
- Partials       1757     1760       +3
Components Coverage Δ
spanner-templates 68.93% <ø> (+<0.01%) ⬆️
spanner-import-export 65.72% <ø> (+0.01%) ⬆️
spanner-live-forward-migration 76.54% <ø> (ø)
spanner-live-reverse-replication 78.80% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)

see 5 files with indirect coverage changes

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Feb 14, 2025 •
edited
Loading

Two tests failed:

JdbcToBigQueryIT.testMySqlToBigQueryWithStorageWriteApi

JdbcToBigQueryIT.testMySqlToBigQueryFlexWithDlq

Error message from worker: org.apache.beam.sdk.util.UserCodeException: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: com.google.protobuf.Descriptors$DescriptorValidationException: Daeb91a54_360e_4da9_8037_ee40d18f7e43.âge: "âge" is not a valid identifier.
	org.apache.beam.sdk.util.UserCodeException.wrap(UserCodeException.java:39)
	org.apache.beam.sdk.io.gcp.bigquery.StorageApiConvertMessages$ConvertMessagesDoFn$DoFnInvoker.invokeProcessElement(Unknown Source)
	org.apache.beam.fn.harness.FnApiDoFnRunner.processElementForParDo(FnApiDoFnRunner.java:810)
Caused by: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: com.google.protobuf.Descriptors$DescriptorValidationException: D39b92aab_0bc0_41b0_b8d2_1ea713d9bfab.âge: "âge" is not a valid identifier.
 at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:592)
 at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:551)
...
 at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4922)
 at org.apache.beam.sdk.io.gcp.bigquery.TwoLevelMessageConverterCache.get(TwoLevelMessageConverterCache.java:66)
 at org.apache.beam.sdk.io.gcp.bigquery.StorageApiConvertMessages$ConvertMessagesDoFn.processElement(StorageApiConvertMessages.java:167)

Looks like BigQuery storage write API does not support non-ascii field name

@pull-request-size pull-request-size bot added size/L and removed size/S labels Feb 14, 2025
@Abacn Abacn force-pushed the non-ascii-test branch 2 times, most recently from 76e018b to 408435f Compare February 14, 2025 04:36
@Abacn Abacn marked this pull request as ready for review February 14, 2025 14:34
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Feb 14, 2025

R: @damccorm

damccorm
damccorm approved these changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit cf55095 into GoogleCloudPlatform:main Feb 14, 2025
14 checks passed
@Abacn Abacn deleted the non-ascii-test branch February 14, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damccorm damccorm damccorm approved these changes

Assignees

No one assigned

Labels

ignore-for-release size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abacn @damccorm