Skip to content

Change default shadow table prefix of reverse replication template#2186

Merged
manitgupta merged 1 commit intoGoogleCloudPlatform:mainfrom
manitgupta:change_default2
Feb 21, 2025
Merged

Change default shadow table prefix of reverse replication template#2186
manitgupta merged 1 commit intoGoogleCloudPlatform:mainfrom
manitgupta:change_default2

Conversation

@manitgupta
Copy link
Copy Markdown
Member

No description provided.

@manitgupta manitgupta requested a review from a team as a code owner February 13, 2025 06:04
@manitgupta manitgupta added the improvement Making existing code better label Feb 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.05%. Comparing base (b51c933) to head (f1afeda).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2186    +/-   ##
==========================================
  Coverage     47.05%   47.05%            
- Complexity     4049     4375   +326     
==========================================
  Files           876      876            
  Lines         52230    52230            
  Branches       5507     5507            
==========================================
  Hits          24578    24578            
  Misses        25892    25892            
  Partials       1760     1760            
Components Coverage Δ
spanner-templates 68.91% <ø> (ø)
spanner-import-export 65.72% <ø> (ø)
spanner-live-forward-migration 76.48% <ø> (ø)
spanner-live-reverse-replication 78.80% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)
Files with missing lines Coverage Δ
...cloud/teleport/v2/templates/SpannerToSourceDb.java 0.00% <ø> (ø)

@manitgupta
Copy link
Copy Markdown
Member Author

Test failures are unrelated to PR. Tests related to reverse replication have passed.

@manitgupta manitgupta merged commit 544ed22 into GoogleCloudPlatform:main Feb 21, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants