Consolidate BigtableChangeStreamsToPubSubIT#2184
Merged
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom Feb 13, 2025
Merged
Consolidate BigtableChangeStreamsToPubSubIT#2184Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Contributor
Author
|
R: @damccorm |
e2299e6 to
7304fea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=========================================
Coverage 46.97% 46.97%
Complexity 4049 4049
=========================================
Files 876 876
Lines 52193 52193
Branches 5502 5502
=========================================
Hits 24517 24517
Misses 25920 25920
Partials 1756 1756
|
Contributor
Author
|
2025-02-13T04:58:39.6233143Z [INFO] googlecloud-to-neo4j ............................... FAILURE [30:08 min] not related to this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce integration to run from 16 to 5.
Template Integration test is expensive. Integration tests are intended to exercise the template functionality on Dataflow runner. However, for test coverage of parameter space it should really be in unit tests.
RunWith(Parameterized) integration tests are discouraged.
The test is flaky, e.g. https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/13296889747/job/37131470159?pr=2182
likely due to too many tests running same time cause Bigtable resource manager fail