Merged
Conversation
There is no clear value add for the error message, simply pushing the raw data is the best way to handle such custom fields
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
============================================
- Coverage 46.95% 46.95% -0.01%
- Complexity 4044 4368 +324
============================================
Files 876 876
Lines 52190 52189 -1
Branches 5501 5501
============================================
- Hits 24506 24505 -1
+ Misses 25926 25925 -1
- Partials 1758 1759 +1
|
claudevdm
approved these changes
Feb 11, 2025
ravijaingit
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no clear value add for the error message, simply pushing the raw data is the best way to handle such custom fields