Fix issues for sequences and identity columns#2171
Merged
darshan-sj merged 11 commits intoGoogleCloudPlatform:mainfrom Feb 20, 2025
Merged
Fix issues for sequences and identity columns#2171darshan-sj merged 11 commits intoGoogleCloudPlatform:mainfrom
darshan-sj merged 11 commits intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
============================================
+ Coverage 46.95% 47.06% +0.10%
- Complexity 4044 4053 +9
============================================
Files 876 876
Lines 52190 52226 +36
Branches 5501 5508 +7
============================================
+ Hits 24507 24580 +73
+ Misses 25924 25887 -37
Partials 1759 1759
|
manitgupta
previously approved these changes
Feb 10, 2025
Member
manitgupta
left a comment
There was a problem hiding this comment.
@darshan-sj Do we also test this functionality in an IT? Do we need to update a corresponding IT as well?
darshan-sj
reviewed
Feb 11, 2025
Contributor
darshan-sj
left a comment
There was a problem hiding this comment.
Can you check ExportPipelineIT and ImportPipelineIT and please add a test case if it is possible to add for this edgecase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues related to sequences and identity columns:
nullstrings appear in identity columns. If a parameter is null, it should not appear in the output file.BIT_REVERSED_POSITIVE_SEQUENCEtobit_reversed_positivebecause theidentity_kindin the information_schema table has a valueBIT_REVERSED_POSITIVE_SEQUENCEwhich is different thanbit_reversed_positive.sequence_kind="default"is not shown properly for the statementCREATE SEQUENCE myseq.