Skip to content

Fix handling of empty arrays, json arrays and jsonb arrays.#2169

Merged
claudevdm merged 2 commits intoGoogleCloudPlatform:mainfrom
claudevdm:template-fixes
Feb 7, 2025
Merged

Fix handling of empty arrays, json arrays and jsonb arrays.#2169
claudevdm merged 2 commits intoGoogleCloudPlatform:mainfrom
claudevdm:template-fixes

Conversation

@claudevdm
Copy link
Copy Markdown
Contributor

No description provided.

@claudevdm claudevdm marked this pull request as ready for review February 7, 2025 03:40
@claudevdm claudevdm requested a review from a team as a code owner February 7, 2025 03:40
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Project coverage is 46.95%. Comparing base (2adaab6) to head (a26fb77).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 58.62% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2169   +/-   ##
=========================================
  Coverage     46.94%   46.95%           
- Complexity     4037     4042    +5     
=========================================
  Files           876      876           
  Lines         52126    52152   +26     
  Branches       5469     5476    +7     
=========================================
+ Hits          24472    24487   +15     
- Misses        25906    25912    +6     
- Partials       1748     1753    +5     
Components Coverage Δ
spanner-templates 68.88% <ø> (ø)
spanner-import-export 65.70% <ø> (ø)
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.67% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)
Files with missing lines Coverage Δ
...oud/teleport/v2/utils/DatastreamToPostgresDML.java 56.75% <58.62%> (+0.50%) ⬆️

liferoad
liferoad previously approved these changes Feb 7, 2025
@claudevdm claudevdm merged commit dae14d7 into GoogleCloudPlatform:main Feb 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants