Added VIRTUAL column support to PG dataflow#2167
Merged
darshan-sj merged 3 commits intoGoogleCloudPlatform:mainfrom Feb 7, 2025
Merged
Added VIRTUAL column support to PG dataflow#2167darshan-sj merged 3 commits intoGoogleCloudPlatform:mainfrom
darshan-sj merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Contributor
|
LGTM on these changes. We will also need to have some tests for FTS - will follow up with you offline on those. |
n-d-joshi
approved these changes
Feb 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
============================================
+ Coverage 46.91% 46.94% +0.03%
- Complexity 4027 4036 +9
============================================
Files 874 876 +2
Lines 52090 52128 +38
Branches 5468 5470 +2
============================================
+ Hits 24436 24472 +36
- Misses 25906 25907 +1
- Partials 1748 1749 +1
|
VardhanThigle
approved these changes
Feb 7, 2025
darshan-sj
reviewed
Feb 7, 2025
Contributor
darshan-sj
left a comment
There was a problem hiding this comment.
No changes are required in InformationSchemaScanner?
Is the feature released in production?
Also, no keyword at the end of the expression currently is defaulted to VIRTUAL ? If so, I'm trying to understand why this change is needed.
Contributor
Author
|
Replying to previous comment inline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R:@n-d-joshi
R:@darshan-sj