Cassandra Bulk - List and Set - Avro Mapping.#2165
Merged
VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom Feb 6, 2025
Merged
Cassandra Bulk - List and Set - Avro Mapping.#2165VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom
VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
============================================
+ Coverage 46.91% 55.13% +8.21%
+ Complexity 4027 1636 -2391
============================================
Files 874 409 -465
Lines 52090 22171 -29919
Branches 5468 2198 -3270
============================================
- Hits 24436 12223 -12213
+ Misses 25906 9232 -16674
+ Partials 1748 716 -1032
|
d2e0c6d to
29fc599
Compare
VardhanThigle
commented
Feb 4, 2025
.../google/cloud/teleport/v2/source/reader/io/cassandra/mappings/CassandraMappingsProvider.java
Show resolved
Hide resolved
Deep1998
reviewed
Feb 5, 2025
...java/com/google/cloud/teleport/v2/source/reader/io/cassandra/mappings/CassandraMappings.java
Show resolved
Hide resolved
Deep1998
reviewed
Feb 5, 2025
...com/google/cloud/teleport/v2/source/reader/io/cassandra/schema/CassandraSchemaDiscovery.java
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good overall, minor nits |
29fc599 to
3bb82b2
Compare
Deep1998
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cassandra Bulk - List and Set - Avro Mapping.
Overview
In bulk migration pipeline, the source rows are mapped to Avro following the unified type mapping (this has been extended by bulk template for Cassandra). The Avro objects are further written to spanner.
This change Discovers and Extracts non-nested
ListandSetCollections from Cassandra and map them to Avro Array.Nested list and set collections will unsupported and hence mapped to
nullas of now.TODO (In future PRs)
TODO (post MVP)