Skip to content

Upgrade upload-artifact version#2164

Merged
damccorm merged 5 commits intomainfrom
users/damccorm/artifact
Jan 31, 2025
Merged

Upgrade upload-artifact version#2164
damccorm merged 5 commits intomainfrom
users/damccorm/artifact

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Jan 31, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.89%. Comparing base (2631a1d) to head (7d257c9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2164      +/-   ##
============================================
- Coverage     46.89%   46.89%   -0.01%     
+ Complexity     4346     4344       -2     
============================================
  Files           874      874              
  Lines         52070    52070              
  Branches       5461     5461              
============================================
- Hits          24420    24416       -4     
- Misses        25906    25909       +3     
- Partials       1744     1745       +1
Components Coverage Δ
spanner-templates 68.80% <ø> (-0.01%) ⬇️
spanner-import-export 65.63% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.67% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)

see 2 files with indirect coverage changes

liferoad
liferoad previously approved these changes Jan 31, 2025
View reviewed changes
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 31, 2025
darshan-sj
darshan-sj approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 4e82f2b into main Jan 31, 2025
@damccorm damccorm deleted the users/damccorm/artifact branch January 31, 2025 20:22
@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Feb 13, 2025

This breaks Java PR Report workflow.

Now individual test failure no longer shown in GitHub Action status. One would need to download "surefire-unit-test-results" and dig into log

Run dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615
==> Repository: GoogleCloudPlatform/DataflowTemplates
==> Artifact name: surefire-test-results
==> Local path: ./
==> Workflow name: 19897455
==> Workflow conclusion: success
==> (not found) Artifact: surefire-test-results
==> Found the following artifacts instead:
	==> (found) Artifact: surefire-unit-test-results
	==> (found) Artifact: surefire-smoke-test-results
	==> (found) Artifact: surefire-integration-test-results

e.g. https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/13300741122/job/37141607962

@Abacn Abacn mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darshan-sj darshan-sj darshan-sj approved these changes

@liferoad liferoad liferoad left review comments

Assignees

No one assigned

Labels

ignore-for-release size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damccorm @Abacn @darshan-sj @liferoad