IT for cross database transaction#2160
Merged
Deep1998 merged 4 commits intoGoogleCloudPlatform:mainfrom Feb 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
============================================
+ Coverage 46.91% 47.05% +0.14%
- Complexity 4027 4373 +346
============================================
Files 874 876 +2
Lines 52090 52223 +133
Branches 5468 5505 +37
============================================
+ Hits 24436 24574 +138
+ Misses 25906 25888 -18
- Partials 1748 1761 +13
|
577df8b to
859b3c1
Compare
...nner/src/test/java/com/google/cloud/teleport/v2/templates/SeparateShadowTableDatabaseIT.java
Outdated
Show resolved
Hide resolved
...nner/src/test/java/com/google/cloud/teleport/v2/templates/SeparateShadowTableDatabaseIT.java
Show resolved
Hide resolved
bharadwaj-aditya
approved these changes
Feb 13, 2025
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
some clarifications - overall looks fine.
...t/java/com/google/cloud/teleport/v2/templates/datastream/ChangeEventSequenceFactoryTest.java
Outdated
Show resolved
Hide resolved
v2/datastream-to-spanner/src/test/resources/SeparateShadowTableDatabaseIT/mysql-schema.sql
Show resolved
Hide resolved
...nner/src/test/java/com/google/cloud/teleport/v2/templates/SeparateShadowTableDatabaseIT.java
Outdated
Show resolved
Hide resolved
darshan-sj
reviewed
Feb 13, 2025
...rc/main/java/com/google/cloud/teleport/v2/templates/datastream/MySqlChangeEventSequence.java
Show resolved
Hide resolved
v2/datastream-to-spanner/src/test/resources/SeparateShadowTableDatabaseIT/mysql-schema.sql
Show resolved
Hide resolved
darshan-sj
approved these changes
Feb 14, 2025
Contributor
darshan-sj
left a comment
There was a problem hiding this comment.
LGTM
Thanks for adding extensive tests!
Contributor
Author
|
Live template ITs have passed, failure due to reverse replication error - b/393963989. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load Tests Pending, will take up in a follow up PR