[Infra] Do not generate shaded jar for common modules#2157
Merged
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom Feb 11, 2025
Merged
[Infra] Do not generate shaded jar for common modules#2157Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2157 +/- ##
============================================
- Coverage 46.89% 46.89% -0.01%
+ Complexity 4346 4345 -1
============================================
Files 874 874
Lines 52070 52070
Branches 5461 5461
============================================
- Hits 24420 24419 -1
Misses 25906 25906
- Partials 1744 1745 +1
|
d8162f7 to
bd0942b
Compare
Contributor
Author
|
I believe this would largely improve the log spam of release workflow log. Current log for Release workflow is 120 MB and almost half are these logs / another half being #1800 |
Contributor
Author
is a flaky test, not related to this change |
darshan-sj
approved these changes
Feb 4, 2025
georgecma
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2158
skipped shaded jar for common modules that do not contain any
@Template