Terraform Sample - Spanner to Cassandra Reverse Replication#2156
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/terraform.tfvars
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/terraform.tfvars
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/variables.tf
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/main.tf
Outdated
Show resolved
Hide resolved
|
Hi @shreyakhajanchi we have pushed the change. Please review it |
|
I don't see the terraform-validator being run for this PR. Can we please include this path so that that check runs? |
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/main.tf
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/main.tf
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/main.tf
Outdated
Show resolved
Hide resolved
What tf validator need to be included ? Is it terraform vet https://cloud.google.com/docs/terraform/policy-validation/quickstart cc - @nasir19noor |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2156 +/- ##
============================================
+ Coverage 46.94% 55.13% +8.18%
+ Complexity 4037 1636 -2401
============================================
Files 876 409 -467
Lines 52126 22171 -29955
Branches 5469 2198 -3271
============================================
- Hits 24472 12223 -12249
+ Misses 25906 9232 -16674
+ Partials 1748 716 -1032
|
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/README.md
Outdated
Show resolved
Hide resolved
v2/spanner-to-sourcedb/terraform/samples/spanner-to-cassandra/main.tf
Outdated
Show resolved
Hide resolved
shreyakhajanchi
left a comment
There was a problem hiding this comment.
The PR looks good overall. Can you rebase the PR so that github actions pass, I have pushed a fix: #2170
@shreyakhajanchi Done |
No description provided.