Skip to content

Terraform Sample - Spanner to Cassandra Reverse Replication#2156

Merged
shreyakhajanchi merged 9 commits intoGoogleCloudPlatform:mainfrom
ollionorg:cassandra_rr_terraform_sample
Feb 10, 2025
Merged

Terraform Sample - Spanner to Cassandra Reverse Replication#2156
shreyakhajanchi merged 9 commits intoGoogleCloudPlatform:mainfrom
ollionorg:cassandra_rr_terraform_sample

Conversation

@taherkl
Copy link
Copy Markdown
Contributor

@taherkl taherkl commented Jan 29, 2025

No description provided.

@taherkl taherkl requested a review from a team as a code owner January 29, 2025 04:57
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jan 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nasir19noor
Copy link
Copy Markdown
Contributor

Hi @shreyakhajanchi we have pushed the change. Please review it

@manitgupta
Copy link
Copy Markdown
Member

I don't see the terraform-validator being run for this PR. Can we please include this path so that that check runs?

@taherkl
Copy link
Copy Markdown
Contributor Author

taherkl commented Feb 4, 2025

I don't see the terraform-validator being run for this PR. Can we please include this path so that that check runs?

What tf validator need to be included ? Is it terraform vet https://cloud.google.com/docs/terraform/policy-validation/quickstart

cc - @nasir19noor

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.13%. Comparing base (2adaab6) to head (3b262fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2156      +/-   ##
============================================
+ Coverage     46.94%   55.13%   +8.18%     
+ Complexity     4037     1636    -2401     
============================================
  Files           876      409     -467     
  Lines         52126    22171   -29955     
  Branches       5469     2198    -3271     
============================================
- Hits          24472    12223   -12249     
+ Misses        25906     9232   -16674     
+ Partials       1748      716    -1032     
Components Coverage Δ
spanner-templates 70.37% <ø> (+1.48%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.67% <ø> (ø)
spanner-bulk-migration 87.94% <ø> (ø)

see 484 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good overall. Can you rebase the PR so that github actions pass, I have pushed a fix: #2170

@taherkl
Copy link
Copy Markdown
Contributor Author

taherkl commented Feb 7, 2025

The PR looks good overall. Can you rebase the PR so that github actions pass, I have pushed a fix: #2170

@shreyakhajanchi Done

@shreyakhajanchi shreyakhajanchi merged commit e6a1f63 into GoogleCloudPlatform:main Feb 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants