Merged
Conversation
Contributor
|
LGTM |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
============================================
+ Coverage 46.89% 46.90% +0.01%
- Complexity 4021 4026 +5
============================================
Files 874 874
Lines 52070 52090 +20
Branches 5461 5468 +7
============================================
+ Hits 24420 24435 +15
Misses 25906 25906
- Partials 1744 1749 +5
|
darshan-sj
reviewed
Jan 28, 2025
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@atask-g - made some minor edits. Can you please review? |
atask-g
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to support Creating Search Index for PG dialect.
This has been tested manually with exporting a database with search indexes and then importing them to verify that the indexes were present,
R: @atask-g