Fix the additional sequence kind options#2146
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Jan 24, 2025
Merged
Fix the additional sequence kind options#2146VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
20e2298 to
9776aa3
Compare
9776aa3 to
a019dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
============================================
+ Coverage 46.75% 46.84% +0.09%
- Complexity 3978 4007 +29
============================================
Files 873 874 +1
Lines 51871 51987 +116
Branches 5429 5441 +12
============================================
+ Hits 24251 24355 +104
- Misses 25894 25895 +1
- Partials 1726 1737 +11
|
VardhanThigle
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
defaultis not added correctly when exporting sequences.tableNameinstead oftableSchemawhen callingGET_TABLE_COLUMN_IDENTITY_STATE.