Changing project id for spanner-staging-tests and run on spanner runners#2127
Merged
darshan-sj merged 7 commits intomainfrom Jan 17, 2025
Merged
Changing project id for spanner-staging-tests and run on spanner runners#2127darshan-sj merged 7 commits intomainfrom
darshan-sj merged 7 commits intomainfrom
Conversation
manitgupta
reviewed
Jan 13, 2025
Member
|
I see that no Spanner tests have been run on this PR.
|
Contributor
Author
I have run the spanner staging workflow on this branch manually and verified that they are running on spanner instances - https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/workflows/spanner-staging-tests.yml I have also configured this workflow to run if there are any changes to the config file itself. It did not get triggered for this PR. |
2ce219e to
4850e03
Compare
4850e03 to
45cc8b0
Compare
manitgupta
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.