Skip to content

Incorporating TODO for Ingesting GCS Config#2104

Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:cassandra-e2e
Jan 3, 2025
Merged

Incorporating TODO for Ingesting GCS Config#2104
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:cassandra-e2e

Conversation

@VardhanThigle
Copy link
Copy Markdown
Contributor

@VardhanThigle VardhanThigle commented Jan 3, 2025 •
edited
Loading

Small Change to fix the Bulk pipeline side of TODO to ingest Driver Config From GCS.

@VardhanThigle VardhanThigle force-pushed the cassandra-e2e branch 2 times, most recently from d444f69 to a4aa183 Compare January 3, 2025 05:14
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.30%. Comparing base (5b0c2cd) to head (c29714c).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2104      +/-   ##
============================================
+ Coverage     46.38%   54.30%   +7.91%     
+ Complexity     3940     1554    -2386     
============================================
  Files           864      396     -468     
  Lines         51358    21469   -29889     
  Branches       5394     2141    -3253     
============================================
- Hits          23823    11658   -12165     
+ Misses        25823     9120   -16703     
+ Partials       1712      691    -1021
Components Coverage Δ
spanner-templates 69.69% <100.00%> (+1.37%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.67% <ø> (ø)
spanner-live-reverse-replication 77.93% <ø> (ø)
spanner-bulk-migration 87.42% <100.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
...der/io/cassandra/iowrapper/CassandraConnector.java 100.00% <100.00%> (+2.94%) ⬆️
...er/io/cassandra/iowrapper/CassandraDataSource.java 100.00% <100.00%> (ø)

... and 486 files with indirect coverage changes

@VardhanThigle VardhanThigle marked this pull request as ready for review January 3, 2025 05:28
@VardhanThigle VardhanThigle requested a review from a team as a code owner January 3, 2025 05:28
@VardhanThigle VardhanThigle changed the title Fixing TODO for Ingesting GCS Config Incorporating TODO for Ingesting GCS Config Jan 3, 2025
@VardhanThigle
Copy link
Copy Markdown
Contributor Author

VardhanThigle commented Jan 3, 2025

Unrelated Failure in spanner-to-sourcedb due to Resource Exhausted. Attempt-2 of this PR had passed for spanner-to-sourcedb.

@VardhanThigle VardhanThigle merged commit 3b1477a into GoogleCloudPlatform:main Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyakhajanchi shreyakhajanchi shreyakhajanchi approved these changes

@Deep1998 Deep1998 Awaiting requested review from Deep1998

@bharadwaj-aditya bharadwaj-aditya Awaiting requested review from bharadwaj-aditya

Assignees

No one assigned

Labels

bug-fix ignore-for-release size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VardhanThigle @shreyakhajanchi