Skip to content

Cassandra DAO Implementation#2072

Merged
asthamohta merged 10 commits intoGoogleCloudPlatform:mainfrom
ollionorg:cassandra_dao_implementation
Dec 20, 2024
Merged

Cassandra DAO Implementation#2072
asthamohta merged 10 commits intoGoogleCloudPlatform:mainfrom
ollionorg:cassandra_dao_implementation

Conversation

@taherkl
Copy link
Copy Markdown
Contributor

@taherkl taherkl commented Dec 18, 2024

Implement IDAO and Unit Test Coverage

  • Implemented the write method in CassandraDao to handle both prepared and simple statements for interacting with Cassandra.
  • Added required Model fro DAO and DML
  • Enhanced test coverage by adding unit tests for the following scenarios:
    • Handling ConnectionException for null connections.
    • Execution of prepared and simple statements via CqlSession

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (8479c8a) to head (f1d7247).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2072      +/-   ##
============================================
- Coverage     50.02%   46.35%   -3.67%     
- Complexity     1543     3931    +2388     
============================================
  Files           428      858     +430     
  Lines         23240    51259   +28019     
  Branches       2308     5391    +3083     
============================================
+ Hits          11625    23762   +12137     
- Misses        10920    25783   +14863     
- Partials        695     1714    +1019     
Components Coverage Δ
spanner-templates 68.17% <100.00%> (-1.17%) ⬇️
spanner-import-export 65.57% <ø> (∅)
spanner-live-forward-migration 76.42% <ø> (ø)
spanner-live-reverse-replication 77.73% <100.00%> (+0.09%) ⬆️
spanner-bulk-migration 87.22% <ø> (+0.05%) ⬆️
Files with missing lines Coverage Δ
.../v2/templates/dbutils/dao/source/CassandraDao.java 100.00% <100.00%> (ø)

... and 451 files with indirect coverage changes

@VardhanThigle VardhanThigle added addition New feature or request ignore-for-release labels Dec 20, 2024
@taherkl
Copy link
Copy Markdown
Contributor Author

taherkl commented Dec 20, 2024

Hi @VardhanThigle Can you please merge this PR as we do not have the rights to do it?

@asthamohta asthamohta merged commit edee6a7 into GoogleCloudPlatform:main Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants