Correcting Partitioning Logic for VarBinary Primary Key Type.#2064
Merged
VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom Dec 19, 2024
Merged
Correcting Partitioning Logic for VarBinary Primary Key Type.#2064VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom
VarBinary Primary Key Type.#2064VardhanThigle merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
246c085 to
2d28d07
Compare
2d28d07 to
52ca2aa
Compare
52ca2aa to
d231ea7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
============================================
+ Coverage 46.31% 54.18% +7.87%
+ Complexity 3919 1542 -2377
============================================
Files 857 389 -468
Lines 51215 21342 -29873
Branches 5389 2141 -3248
============================================
- Hits 23719 11565 -12154
+ Misses 25783 9085 -16698
+ Partials 1713 692 -1021
|
d231ea7 to
c3e33b3
Compare
f6500c7 to
621df32
Compare
3b1b277 to
f60a6d9
Compare
f60a6d9 to
ac2ada7
Compare
Deep1998
reviewed
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting Collation Mapping Query for Varbinary. Adding Integration test for all supported Pkey types on MySql.
Overview
For
VarBinary, the collation used isbinarywhich also happens to be a reserved keyword. We need to escape it.With Support for mapping to
bigIntegersin this PR, we are directly mapping binary columns to bigIntegers as thebinarycollation is always ordered by the value of the byte.Also for future proofing, all the collations and character sets on
MySqlwill be escaped with abacktick.Please refer to https://dev.mysql.com/doc/refman/8.4/en/charset-binary-collations.html for more details.
Testing
Big Int UnsignedandVarBinarysucceeds.TODO (For Followup PR):