Cassandra datatype handler#2054
Merged
shreyakhajanchi merged 19 commits intoGoogleCloudPlatform:mainfrom Dec 17, 2024
Merged
Conversation
Sync master
* Added Type Handler for Cassandra * Added UT
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
* Refectored the code * Handle Minor fixes * Casting fixes PR review comments fixed
* updated comments
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
* Resolve review comments and added test cases for null, min, max and incorrect value format * Handle Exception * Handle INet * Handle Code Formate * Added format and removeed raw import * Added Null handling * Added test cases for all remaining of cassandra datatype
Contributor
Author
|
@shreyakhajanchi @VardhanThigle We have addressed all the review comments. Requesting your review for the same. Please close the comment if the addressed changes are aligned with the expectations. Thanks! |
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
* removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Outdated
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Outdated
Show resolved
Hide resolved
* removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply * Fixed the review comments and add Test with a non-zero offset and happy test * Fixed the review comments and add Test with a non-zero offset and happy test * Handle Sppoty fixes --------- Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
============================================
+ Coverage 45.95% 46.31% +0.35%
- Complexity 3792 4243 +451
============================================
Files 850 857 +7
Lines 50764 51215 +451
Branches 5340 5389 +49
============================================
+ Hits 23331 23718 +387
- Misses 25741 25783 +42
- Partials 1692 1714 +22
|
* Fixed review comments and increased coverage
...c/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandlerTest.java
Show resolved
Hide resolved
* Fixed UT for Inetaddress
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
...b/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraTypeHandler.java
Show resolved
Hide resolved
shreyakhajanchi
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Type handler will be used for Casting source type(Spanner) to Cassandra Cassandra-supported type.
This code covers the support for:
// TODO - We are going to create a common method which will be the common integration point of this class and then we will mark all of these methods as private. we have kept this method public for a while to wire up UT.