Skip to content

Adding dataflow timestamp field in datastream-common json flow#2042

Merged
shreyakhajanchi merged 2 commits intoGoogleCloudPlatform:mainfrom
shreyakhajanchi:time-tree-fix
Dec 5, 2024
Merged

Adding dataflow timestamp field in datastream-common json flow#2042
shreyakhajanchi merged 2 commits intoGoogleCloudPlatform:mainfrom
shreyakhajanchi:time-tree-fix

Conversation

@shreyakhajanchi
Copy link
Copy Markdown
Contributor

_metadata_dataflow_timestamp was added as a field in change event in datastream-common for avro flow as part of this PR. Adding the same field to json flow.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.93%. Comparing base (9854a70) to head (ccd64dc).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2042      +/-   ##
============================================
- Coverage     45.93%   45.93%   -0.01%     
- Complexity     3780     4104     +324     
============================================
  Files           849      849              
  Lines         50630    50632       +2     
  Branches       5319     5319              
============================================
  Hits          23256    23256              
- Misses        25690    25691       +1     
- Partials       1684     1685       +1     
Components Coverage Δ
spanner-templates 67.51% <ø> (-0.02%) ⬇️
spanner-import-export 65.47% <ø> (-0.04%) ⬇️
spanner-live-forward-migration 76.30% <ø> (ø)
spanner-live-reverse-replication 77.23% <ø> (ø)
spanner-bulk-migration 86.85% <ø> (ø)
Files with missing lines Coverage Δ
...astream/transforms/FormatDatastreamJsonToJson.java 61.46% <100.00%> (+0.72%) ⬆️

... and 1 file with indirect coverage changes

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Dec 2, 2024
@shreyakhajanchi shreyakhajanchi merged commit ff14f97 into GoogleCloudPlatform:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants