Skip to content

Setting useCursorFetch for MySql if FetchSize is configured.#2041

Merged
bharadwaj-aditya merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:fetchsize
Dec 2, 2024
Merged

Setting useCursorFetch for MySql if FetchSize is configured.#2041
bharadwaj-aditya merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle:fetchsize

Conversation

@VardhanThigle
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.41%. Comparing base (9854a70) to head (09b06c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2041      +/-   ##
============================================
+ Coverage     45.93%   53.41%   +7.47%     
+ Complexity     3780     1416    -2364     
============================================
  Files           849      382     -467     
  Lines         50630    20870   -29760     
  Branches       5319     2101    -3218     
============================================
- Hits          23256    11147   -12109     
+ Misses        25690     9045   -16645     
+ Partials       1684      678    -1006     
Components Coverage Δ
spanner-templates 68.59% <100.00%> (+1.06%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.30% <ø> (ø)
spanner-live-reverse-replication 77.23% <ø> (ø)
spanner-bulk-migration 86.87% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...ud/teleport/v2/options/OptionsToConfigBuilder.java 95.09% <100.00%> (+0.47%) ⬆️

... and 484 files with indirect coverage changes

@VardhanThigle VardhanThigle marked this pull request as ready for review December 2, 2024 07:20
@VardhanThigle VardhanThigle requested a review from a team as a code owner December 2, 2024 07:20
Copy link
Copy Markdown
Contributor

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharadwaj-aditya bharadwaj-aditya merged commit 28653c6 into GoogleCloudPlatform:main Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants