custom transformation implementation#2040
Merged
shreyakhajanchi merged 3 commits intoGoogleCloudPlatform:mainfrom Dec 4, 2024
Merged
custom transformation implementation#2040shreyakhajanchi merged 3 commits intoGoogleCloudPlatform:mainfrom
shreyakhajanchi merged 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
============================================
+ Coverage 45.60% 45.95% +0.34%
- Complexity 3729 4114 +385
============================================
Files 847 850 +3
Lines 50188 50759 +571
Branches 5275 5338 +63
============================================
+ Hits 22887 23324 +437
- Misses 25629 25741 +112
- Partials 1672 1694 +22
|
Deep1998
reviewed
Dec 2, 2024
...cedb/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/MySQLDMLGenerator.java
Outdated
Show resolved
Hide resolved
Deep1998
reviewed
Dec 2, 2024
...cedb/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/MySQLDMLGenerator.java
Outdated
Show resolved
Hide resolved
Deep1998
reviewed
Dec 2, 2024
...main/java/com/google/cloud/teleport/v2/templates/dbutils/processor/InputRecordProcessor.java
Show resolved
Hide resolved
Contributor
|
We also need some sort of exhaustive units tests covering all supported response java types and ensure the right DML gets generated, besides end-to-end ITs. |
Deep1998
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spanner-to-sourcedbreverse replication templateFilterEventsDirectoryName