Fixing Custom Transforms for BigInt Unsigned and Boolean types.#2039
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Nov 29, 2024
Merged
Fixing Custom Transforms for BigInt Unsigned and Boolean types.#2039VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
BigInt Unsigned and Boolean types.#2039VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
0ffea90 to
35a4579
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
============================================
+ Coverage 45.60% 53.39% +7.78%
+ Complexity 3729 1413 -2316
============================================
Files 847 382 -465
Lines 50188 20861 -29327
Branches 5275 2100 -3175
============================================
- Hits 22887 11138 -11749
+ Misses 25629 9045 -16584
+ Partials 1672 678 -994
|
35a4579 to
9ceed97
Compare
c7ea5cb to
24144d9
Compare
VardhanThigle
commented
Nov 29, 2024
...in/java/com/google/cloud/teleport/v2/spanner/migrations/avro/GenericRecordTypeConvertor.java
Show resolved
Hide resolved
...oogle/cloud/teleport/v2/source/reader/io/jdbc/rowmapper/provider/MysqlJdbcValueMappings.java
Outdated
Show resolved
Hide resolved
...gle/cloud/teleport/v2/source/reader/io/schema/typemapping/provider/MysqlMappingProvider.java
Show resolved
Hide resolved
bharadwaj-aditya
previously approved these changes
Nov 29, 2024
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Minor comments. LGTM
24144d9 to
a2b5e09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Custom Transforms for
BigInt UnsignedandBooleantypes.Overview of Changes
BytesandBoolean.BigInt UnsignedtoAvro Number Logical Typeas per updates in unified mapping.