Allowing Jdbc FetchSize Configuration for handling large rows#2028
Merged
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom Nov 28, 2024
Merged
Allowing Jdbc FetchSize Configuration for handling large rows#2028VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
VardhanThigle merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
============================================
+ Coverage 45.40% 52.97% +7.56%
+ Complexity 3680 1371 -2309
============================================
Files 843 378 -465
Lines 49989 20680 -29309
Branches 5261 2092 -3169
============================================
- Hits 22700 10955 -11745
+ Misses 25620 9045 -16575
+ Partials 1669 680 -989
|
...-to-spanner/src/main/java/com/google/cloud/teleport/v2/options/SourceDbToSpannerOptions.java
Outdated
Show resolved
Hide resolved
...-to-spanner/src/main/java/com/google/cloud/teleport/v2/options/SourceDbToSpannerOptions.java
Outdated
Show resolved
Hide resolved
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Comments around the help text, rest looks fine.
fcff0c4 to
510bda1
Compare
...rc/main/java/com/google/cloud/teleport/v2/source/reader/io/jdbc/iowrapper/JdbcIoWrapper.java
Show resolved
Hide resolved
fb6922f to
7d3a556
Compare
manitgupta
previously approved these changes
Nov 25, 2024
2f3e114 to
11bc6c2
Compare
6 tasks
bharadwaj-aditya
approved these changes
Nov 28, 2024
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
minor suggestion on config. Rest looks fine.
...-to-spanner/src/main/java/com/google/cloud/teleport/v2/options/SourceDbToSpannerOptions.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing Jdbc FetchSize Configuration for handling large rows.
Overview
Default fetch size used by
JdbcIOis 50_000 rows.Large (in terms of memory size) rows can lead to memory errors and
JdbcIOrecommends tuning fetch size in case of memory errors. Please see here.Here we allow the user to tune the fetch size via parameters.
Auto inference of fetchsize will be taken as a separate task as it needs careful scale testing.