add KMS key support to BigQueryConverters#2024
Merged
Polber merged 2 commits intoGoogleCloudPlatform:mainfrom Nov 27, 2024
Merged
add KMS key support to BigQueryConverters#2024Polber merged 2 commits intoGoogleCloudPlatform:mainfrom
Polber merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
============================================
- Coverage 45.41% 45.41% -0.01%
- Complexity 3677 4001 +324
============================================
Files 842 842
Lines 49970 49970
Branches 5261 5262 +1
============================================
- Hits 22696 22695 -1
Misses 25605 25605
- Partials 1669 1670 +1
|
liferoad
reviewed
Nov 19, 2024
v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
liferoad
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for encrypting temporary table created during BigQueryIO read for any templates that use the BigQueryConverters class (v2) to read from BigQuery.
This only applies when using
queryto read from the BigQuery source