Parameterizing spanner Host in spanner tests#2020
Merged
darshan-sj merged 7 commits intoGoogleCloudPlatform:mainfrom Dec 3, 2024
Merged
Parameterizing spanner Host in spanner tests#2020darshan-sj merged 7 commits intoGoogleCloudPlatform:mainfrom
darshan-sj merged 7 commits intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
============================================
+ Coverage 45.51% 45.92% +0.41%
- Complexity 3704 4101 +397
============================================
Files 845 850 +5
Lines 50084 50635 +551
Branches 5268 5318 +50
============================================
+ Hits 22794 23253 +459
- Misses 25618 25695 +77
- Partials 1672 1687 +15
|
manitgupta
reviewed
Nov 21, 2024
v1/src/test/java/com/google/cloud/teleport/spanner/ExportPipelineIT.java
Outdated
Show resolved
Hide resolved
manitgupta
reviewed
Nov 21, 2024
v1/src/test/java/com/google/cloud/teleport/spanner/ExportPipelineIT.java
Show resolved
Hide resolved
manitgupta
reviewed
Nov 21, 2024
it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/TemplateTestBase.java
Show resolved
Hide resolved
d307f51 to
7258e53
Compare
manitgupta
reviewed
Nov 27, 2024
...oogle-cloud-platform/src/main/java/org/apache/beam/it/gcp/spanner/SpannerTemplateITBase.java
Show resolved
Hide resolved
Polber
reviewed
Nov 27, 2024
Contributor
Polber
left a comment
There was a problem hiding this comment.
LGTM - much cleaner than the existing solution. I will let someone from Spanner give the official approval
Also, there is other cleanup that will be required either in this PR, or I can submit the following changes after this PR is merged: main...Polber:DataflowTemplates:jkinard/spanner-cleanup
manitgupta
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.