Formatting changes to templates#1667
Merged
liferoad merged 21 commits intoGoogleCloudPlatform:mainfrom Dec 12, 2024
Merged
Conversation
rszper
approved these changes
Jul 1, 2024
Contributor
rszper
left a comment
There was a problem hiding this comment.
Thank you for making these updates. It's going to look much better.
v1/src/main/java/com/google/cloud/teleport/bigtable/BigtableToVectorEmbeddings.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/options/CommonTemplateOptions.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/options/WindowedFilenamePolicyOptions.java
Outdated
Show resolved
Hide resolved
v2/common/src/main/java/com/google/cloud/teleport/v2/options/WindowedFilenamePolicyOptions.java
Outdated
Show resolved
Hide resolved
...eam-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/DataStreamToSpanner.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/cloud/teleport/v2/elasticsearch/options/ElasticsearchWriteOptions.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/cloud/teleport/v2/elasticsearch/options/ElasticsearchWriteOptions.java
Outdated
Show resolved
Hide resolved
.../main/java/com/google/cloud/teleport/v2/elasticsearch/options/ElasticsearchWriteOptions.java
Outdated
Show resolved
Hide resolved
...a-common/src/main/java/com/google/cloud/teleport/v2/kafka/options/SchemaRegistryOptions.java
Outdated
Show resolved
Hide resolved
v2/kafka-to-pubsub/src/main/java/com/google/cloud/teleport/v2/options/KafkaToPubsubOptions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Contributor
Author
|
@rszper Please confirm if these changes are good ? If yes, I will proceed to generate readme docs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
============================================
+ Coverage 45.56% 45.96% +0.39%
- Complexity 3721 4124 +403
============================================
Files 847 851 +4
Lines 50169 50805 +636
Branches 5273 5343 +70
============================================
+ Hits 22862 23351 +489
- Misses 25632 25760 +128
- Partials 1675 1694 +19
|
yair-harel
previously approved these changes
Sep 19, 2024
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Comment for Spanner templates - Minor comment on the import pipeline. rest looks fine.
ron-gal
reviewed
Sep 19, 2024
Contributor
ron-gal
left a comment
There was a problem hiding this comment.
Minor format comments, otherwise LGTM for bigtable changes
v2/googlecloud-to-googlecloud/README_Bigtable_Change_Streams_to_BigQuery.md
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/teleport/v2/options/BigtableChangeStreamToBigQueryOptions.java
Outdated
Show resolved
Hide resolved
rszper
reviewed
Sep 19, 2024
Contributor
rszper
left a comment
There was a problem hiding this comment.
It looks like there's a lot of repetition, so the edits that I suggested should be applied to the later files as well.
v2/googlecloud-to-elasticsearch/README_GCS_to_Elasticsearch_Xlang.md
Outdated
Show resolved
Hide resolved
v2/googlecloud-to-elasticsearch/README_GCS_to_Elasticsearch_Xlang.md
Outdated
Show resolved
Hide resolved
v2/googlecloud-to-elasticsearch/README_GCS_to_Elasticsearch_Xlang.md
Outdated
Show resolved
Hide resolved
v2/googlecloud-to-elasticsearch/README_GCS_to_Elasticsearch_Xlang.md
Outdated
Show resolved
Hide resolved
Polber
previously approved these changes
Sep 19, 2024
Contributor
Polber
left a comment
There was a problem hiding this comment.
LGTM so long as other comments are addressed
v2/kafka-common/src/main/java/com/google/cloud/teleport/v2/kafka/options/KafkaReadOptions.java
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
0daaae1
e516e6b to
c173f1e
Compare
| outputDirectory = "<outputDirectory>" | ||
| # sourceDbDialect = "MYSQL" | ||
| # jdbcDriverJars = "gs://your-bucket/driver_jar1.jar,gs://your-bucket/driver_jar2.jar" | ||
| # jdbcDriverJars = "" |
Contributor
There was a problem hiding this comment.
Could we add "<gsPathToDriverJars>" here?
| # numPartitions = "0" | ||
| # spannerHost = "https://batch-spanner.googleapis.com" | ||
| # maxConnections = "-1" | ||
| # maxConnections = "0" |
Contributor
There was a problem hiding this comment.
Generally -1 is preferred (which is also the default). -1 indicates no limits on connections. The user can configure a non-negaitve value in case they need to reduce the number of active connections per worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed formatting.