Apache BEAM SDK updates to handle vector length column annotation#1392
Merged
copybara-service[bot] merged 4 commits intoGoogleCloudPlatform:mainfrom Mar 28, 2024
Merged
Apache BEAM SDK updates to handle vector length column annotation#1392copybara-service[bot] merged 4 commits intoGoogleCloudPlatform:mainfrom
copybara-service[bot] merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
Contributor
ambujojha
commented
Mar 25, 2024
- Updates in SpannerSchema.java
- No updates necessary in MutationSizeEstimator.java
darshan-sj
reviewed
Mar 26, 2024
v1/src/test/java/com/google/cloud/teleport/spanner/SpannerServerResource.java
Outdated
Show resolved
Hide resolved
v1/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
Outdated
Show resolved
Hide resolved
darshan-sj
previously approved these changes
Mar 27, 2024
jonathan-lemos
approved these changes
Mar 27, 2024
v1/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
Outdated
Show resolved
Hide resolved
darshan-sj
approved these changes
Mar 28, 2024
Contributor
|
Please sync this update to Beam repo. LocalSpannerIO will be removed (#1362) and this change will get lost |
Contributor
Author
Sure. How much time do I have? |
Contributor
The next Beam release cut date is Apr 17, 2024. It's nice to have Beam PR merge it by that time so this would unblock tearing down LocalSpannerIO when Templates upgrade to Beam 2.56.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.