Add console warnings if a shortcut has been skipped.#122
Merged
andreban merged 4 commits intoGoogleChromeLabs:masterfrom Mar 11, 2020
Merged
Add console warnings if a shortcut has been skipped.#122andreban merged 4 commits intoGoogleChromeLabs:masterfrom
andreban merged 4 commits intoGoogleChromeLabs:masterfrom
Conversation
Contributor
Author
|
@andreban Do you mind taking a look |
Member
|
Have you considered using |
Contributor
Author
|
Changed this to use Log.ts |
andreban
approved these changes
Mar 11, 2020
| generatorApp: string; | ||
| webManifestUrl?: URL; | ||
|
|
||
| private static log: Log = new Log('twa-manifest'); |
Member
There was a problem hiding this comment.
nit: I've been passing a log object in the constructor, but initialising with a default value. This helps with tests so those don't pollute the console. But I'm ok to keep like this too.
Contributor
Author
There was a problem hiding this comment.
It's being used from within a static function though. I could make it a module-level constant but that won't help with the pollution issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #116