CI: Fix Chrome version discrepancy#3493
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workbox integration tests fail in CI when chromedriver (updated via
npm install --no-save) is newer than the Chrome browser version cached by selenium-assistant.The current cache key is static (
${{ runner.os }}), meaning once the cache is created, it is never updated with newer browser versions.I first addressed this by making the cache key more dynamic, but that wasn't good enough. The main change now is that the browser is first installed via selenium-assistant and then the matching chromedriver verison is installed.
To verify: tests should now pass again.